Fantom

Login | Register

Make fwt::TreeModel.children non-nullable #865

tactics
11 Dec 2009

fwt::TreeModel.children has a nullable return type. However, the default implementation of has children requires the value to be non-null.

// From src/fwt/fan/Tree.fan
virtual Bool hasChildren(Obj node) { return !children(node).isEmpty }
virtual Obj[]? children(Obj node) { return null }

It seems to me like the return type on children should simply be made non-nullable. Why have two different ways to show you're subtree is empty?

helium
11 Dec 2009

All your base are belong to us

brian
12 Dec 2009

Renamed from fwt::TreeModel Error to Make fwt::TreeModel.children non-nullable

brian
12 Dec 2009

Promoted to ticket #865 and assigned to brian

brian
12 Dec 2009

Ticket resolved in 1.0.48

changeset

Login or Register to Reply

Back | All Topics