And fix and verify the rest of that class. I'd like to use that convention - all fields should prefix with m_. And then I'll pull this into core.
andyWed 27 Jul 2011
Tho looks like you are missing some methods on Regex - most importantly fromStr - we'll need to flush all those out as well. Verify you can actually invoke this code from Fantom compiled code.
jessevdamWed 27 Jul 2011
I put complete code for both, I did run self made test script in the browser chrome. Did yet run the full test from the fantom test suite, as which i will do later.
andyWed 27 Jul 2011
Awesome - didn't realize I had already stubbed some of that code out - but thanks.
SlimerDudeThu 20 Aug 2015
Investigating Javascript errors in BeanUtils led me here!
Any reason why we still don't have a Javascript version of RegexMatcher? I understand that start() and end() can't be implemented, but it looks like the rest could be, no?
andyThu 20 Aug 2015
If you want to pull this into a patch and verify test suite - we can merge it in.
SlimerDudeMon 24 Aug 2015
@andy, I've just emailed you the patch. Lemme know if it didn't get through.
jessevdam Wed 27 Jul 2011
I created some code which implements the regexp matcher in javascript
javascript for RegexMatcher
java script for Regex.js
There is no support for the start and end function in javascript, only for the start off group 0
EDIT: Putting the complete code not only the new codes
andy Wed 27 Jul 2011
Great - thanks jessevdam - can you make one change tho (just edit your post - don't need a new reply):
And fix and verify the rest of that class. I'd like to use that convention - all fields should prefix with
m_
. And then I'll pull this into core.andy Wed 27 Jul 2011
Tho looks like you are missing some methods on
Regex
- most importantlyfromStr
- we'll need to flush all those out as well. Verify you can actually invoke this code from Fantom compiled code.jessevdam Wed 27 Jul 2011
I put complete code for both, I did run self made test script in the browser chrome. Did yet run the full test from the fantom test suite, as which i will do later.
andy Wed 27 Jul 2011
Awesome - didn't realize I had already stubbed some of that code out - but thanks.
SlimerDude Thu 20 Aug 2015
Investigating Javascript errors in BeanUtils led me here!
Any reason why we still don't have a Javascript version of
RegexMatcher
? I understand thatstart()
andend()
can't be implemented, but it looks like the rest could be, no?andy Thu 20 Aug 2015
If you want to pull this into a patch and verify test suite - we can merge it in.
SlimerDude Mon 24 Aug 2015
@andy
, I've just emailed you the patch. Lemme know if it didn't get through.andy Tue 25 Aug 2015
Landed - changeset
Thanks @jessevdam and @SlimerDude