Looking at Wisp::FileWeblet I think you fell into the same trap I did when looking at the Accept-Encoding encoding header.
Accept-Encoding
RFC2616 sec 14.3 talks of quality values meaning a HTTP header of:
Accept-Encoding: compress;q=0.5, gzip;q=0.0
means gzip is NOT accepted. FileWeblet currently just checks to see if the header contains "gzip", which would fail the above example:
gzip
FileWeblet
ae := req.headers["Accept-Encoding"] ?: "" if (mime?.mediaType == "text" && ae.contains("gzip")) { ... }
Good catch. Have you actually ever seen that in the field?
I pushed a fix
In dev I've not seen the main browsers issue q-values, but in live I've not monitored the Accept-Encoding header to see if anyone else does.
Login or Signup to reply.
SlimerDude Mon 29 Jul 2013
Looking at Wisp::FileWeblet I think you fell into the same trap I did when looking at the
Accept-Encodingencoding header.RFC2616 sec 14.3 talks of quality values meaning a HTTP header of:
means
gzipis NOT accepted.FileWebletcurrently just checks to see if the header contains "gzip", which would fail the above example:ae := req.headers["Accept-Encoding"] ?: "" if (mime?.mediaType == "text" && ae.contains("gzip")) { ... }brian Wed 31 Jul 2013
Good catch. Have you actually ever seen that in the field?
I pushed a fix
SlimerDude Wed 31 Jul 2013
In dev I've not seen the main browsers issue q-values, but in live I've not monitored the Accept-Encoding header to see if anyone else does.