It might be nice to move the indent/unindent functionality from CompilerLog into the main Log class sometime. Could come in handy for other code.
brianMon 22 Jun 2009
I can see how that might be handy, but I'm not sure it makes sense. CompilerLog subclasses Log to get its levels stuff, but uses it more like a print stream. The core Log abstract itself doesn't necessarily map to a print stream. For example you might log to records in a database.
tompalmerTue 23 Jun 2009
For example you might log to records in a database.
Good point. It could be considered a hint, still. Maybe worth keeping in mind in case it seems handy later.
tompalmer Mon 22 Jun 2009
It might be nice to move the indent/unindent functionality from
CompilerLoginto the mainLogclass sometime. Could come in handy for other code.brian Mon 22 Jun 2009
I can see how that might be handy, but I'm not sure it makes sense. CompilerLog subclasses Log to get its levels stuff, but uses it more like a print stream. The core Log abstract itself doesn't necessarily map to a print stream. For example you might log to records in a database.
tompalmer Tue 23 Jun 2009
Good point. It could be considered a hint, still. Maybe worth keeping in mind in case it seems handy later.