#803 fan.sys.List.remove() missed for JavaScript

Collapse AllExpand All

Yuri Strot Thu 22 Oct 2009

Seems like sys::List.remove never used before from the Java Script :-) The patch looks simple:

diff --git a/src/sys/js/fan/List.js b/src/sys/js/fan/List.js
--- a/src/sys/js/fan/List.js
+++ b/src/sys/js/fan/List.js
@@ -84,6 +84,13 @@
   return self;
 }
 
+fan.sys.List.remove = function(self, val)
+{
+  var index = fan.sys.List.index(self, val);
+  if (index == null) return null;
+  return fan.sys.List.removeAt(self, index);
+}
+
 fan.sys.List.removeSame = function(self, val)
 {
   var index = fan.sys.List.indexSame(self, val);

andy Thu 22 Oct 2009

Thanks ystrot - pushed fix

Login or Signup to reply.